piraeus-operator icon indicating copy to clipboard operation
piraeus-operator copied to clipboard

app.kubernetes.io/name should not be the same

Open maxpain opened this issue 1 year ago • 1 comments

Hello.

Currently, all the pods in piraeus-datastore namespace have the same app.kubernetes.io/name=piraeus-datastore label, which is not ideal.

For example, it's used in Hubble UI as an identity for traffic flows.

Screenshot 2024-10-12 at 20 40 17

maxpain avatar Oct 12 '24 17:10 maxpain

That is unfortunate. I guess we should have used app.kubernetes.io/part-of: piraeus-datastore instead.

However, because this label is included in the selectors, I'm hesitant to change it, as that would require a complete delete/recreate of the deployments.

WanzenBug avatar Oct 14 '24 05:10 WanzenBug