finance-go
finance-go copied to clipboard
Actually return an error for unknown symbol
quote.Get
of an inexistent symbol should return a non nil error.
This does not happen....
To repro ask for a quote from a un-existant symbol:
package main
import (
"fmt"
"github.com/piquette/finance-go/quote"
)
func main() {
q, err := quote.Get("FOOAASDADSAS") // <---- panic here because both `q` and `err` are `nil`
if err != nil {
panic(err)
}
fmt.Printf("RegulardMarketPrice: %# +v", q.RegularMarketPrice)
}
This will panic:
$ go run .
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x50 pc=0x620b2e]
goroutine 1 [running]:
main.main()
/home/pallotron/projects/example/ticker-quote.go:14 +0x2e
exit status 2
[Exit code 1 @ 10:12:01]
get.Quote
should return an error in this case.
Hello? Can you review this please? :)
@ackleymi, @jacks821 @pkaeding can you guys please stamp this?
@ackleymi Could you merge this? This is the only error I encounter with this library so far and I think many people would be happy if they don't get a panic and a error instead.
this project is very active :D
this project is very active :D
Seems abandoned.
Is there any forks maintained?
@pallotron Please feel free to bring this change to my fork, https://github.com/sunglim/yh-finance-go