pippo icon indicating copy to clipboard operation
pippo copied to clipboard

Add protobuf support

Open denysvitali opened this issue 5 years ago • 5 comments

denysvitali avatar Jun 05 '19 07:06 denysvitali

Interesting. This PR is a particular case of #407. I will push my work on GitHub in a separate branch to make my work public.

decebals avatar Jun 05 '19 08:06 decebals

Does my work look good? I think this may solve #407 as well, as you said :+1:

denysvitali avatar Jun 05 '19 08:06 denysvitali

I use it like this, where LoginResponse obviously is a Protobuf Message:

ctx.status(HttpStatus.OK_200);
if(req.getUsername().equals("user") && req.getPassword().equals("password")){
resp = LoginResponse.newBuilder()
      .setSuccess(true)
      .setMessage("Login successful")
      .build();
  ctx.protobuf().send(resp);
} else {
  resp = LoginResponse.newBuilder()
      .setSuccess(false)
      .setMessage("Invalid username/password")
      .build();
  ctx.protobuf().send(resp);
}

denysvitali avatar Jun 05 '19 08:06 denysvitali

Does my work look good? I think this may solve #407 as well, as you said

I will do an evaluation and I will come with a response. Thanks!

decebals avatar Jun 05 '19 08:06 decebals