Piper Merriam
Piper Merriam
@njsmith I'd be curious to get your feedback on this proof-of-concept for a `run_in_process` function. https://github.com/ethereum/trinity/pull/1079/files Specifically, I'm interested in what you think about how I leveraged the trio subprocess...
@njsmith great feedback and lots of good pointers. I spent another few hours tinkering and have things in a state that I'm starting to get *more* happy with. I'm not...
I think the right place to catch this is in in [`solc/wrapper.py#L53`](https://github.com/ethereum/py-solc/blob/3a6de359dc31375df46418e6ffd7f45ab9567287/solc/wrapper.py#L53) and to use `solc.utils.filesystem.is_executable_available` to check that `solc_binary` is present. We can then raise a `FileNotFound` error with...
Yeah, if `solc` isn't on your `$PATH` you can either add it to your `$PATH` or set the environment variable `SOLC_BINARY` to the path to the `solc` executable.
This would be a big improvement over the current subprocess based implementation.
@miohtama awkward. I think this is only related because you have `parity` installed and part of the install scripts for the solc compiler involves running a `brew upgrade`.
dataclasses could be a nice way to do this but I'm not inclined to force it.
??? not sure I like this but it might make sense. ```python handle = endpoint.add_event_handler(MyEvent, do_thing_with_event) # this is the primary API endpoint.remove_event_handler(handle) # this is convenience that delegates to...
cc @cburgdorf wonder what you think about this. It catches errors like the following ```rst This ``code` is not correctly closed ``` But it also errors on things like this...
I thought about doing it that way (actual generation of the changelog) but it's a stateful and destructive action and for us to be able to do that test we'd...