legendary-rune-maker icon indicating copy to clipboard operation
legendary-rune-maker copied to clipboard

Published 20 hours ago • verified publisher icon pipe01

Fix opgg provider

Open rincew1nd opened this issue 5 years ago • 3 comments

Fetching of item builds from op.gg. Haven't tested it in-game, but should work properly.

rincew1nd avatar Apr 04 '19 23:04 rincew1nd

Yeah it's just preference, I usually write all my code using vars for all types except primitives

pipe01 avatar Mar 01 '21 15:03 pipe01

Ah, okie dokes, thank you :)

Chobocharles avatar Mar 01 '21 15:03 Chobocharles

Yeah. like @pipe01 said, it's just a coding style that i'm using (for work and hobby projects). I'm explicitly defining types when boxing could fail or compiler could not automatically resolve a type.

Also i believe that this PR is outdated as hell, cause markdown could be changed many times for past 2 years.

rincew1nd avatar Mar 10 '21 11:03 rincew1nd