pipecd icon indicating copy to clipboard operation
pipecd copied to clipboard

feat: Implement project enabling/disabling functionality

Open niladrix719 opened this issue 1 month ago • 2 comments

What this PR does:

  • Adds Disable option in project settings (no new logins or API calls are allowed until it is re-enabled)
  • Adds a Disable and Enable Field in Owner page
Screenshot 2025-11-26 at 9 41 28 PM Screenshot 2025-11-26 at 6 56 37 PM Screenshot 2025-11-26 at 7 59 50 PM Screenshot 2025-11-27 at 2 00 19 AM

Why we need it:

Which issue(s) this PR fixes:

Fixes #4754

niladrix719 avatar Nov 26 '25 20:11 niladrix719

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 17.50%. Comparing base (9fdf3c8) to head (48c7ebc).

:exclamation: There is a different number of reports uploaded between BASE (9fdf3c8) and HEAD (48c7ebc). Click for more details.

HEAD has 10 uploads less than BASE
Flag BASE (9fdf3c8) HEAD (48c7ebc)
.-pkg-app-pipedv1-plugin-terraform 1 0
.-pkg-app-pipedv1-plugin-waitapproval 1 0
.-pkg-app-pipedv1-plugin-scriptrun 1 0
.-pkg-app-pipedv1-plugin-wait 1 0
.-pkg-app-pipedv1-plugin-analysis 1 0
.-tool-actions-plan-preview 1 0
.-pkg-plugin-sdk 1 0
.-pkg-app-pipedv1-plugin-kubernetes 1 0
. 1 0
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6363       +/-   ##
===========================================
- Coverage   28.82%   17.50%   -11.33%     
===========================================
  Files         560        7      -553     
  Lines       59941      920    -59021     
===========================================
- Hits        17277      161    -17116     
+ Misses      41343      738    -40605     
+ Partials     1321       21     -1300     
Flag Coverage Δ
. ?
.-pkg-app-pipedv1-plugin-analysis ?
.-pkg-app-pipedv1-plugin-kubernetes ?
.-pkg-app-pipedv1-plugin-kubernetes_multicluster ?
.-pkg-app-pipedv1-plugin-scriptrun ?
.-pkg-app-pipedv1-plugin-terraform ?
.-pkg-app-pipedv1-plugin-wait ?
.-pkg-app-pipedv1-plugin-waitapproval ?
.-pkg-plugin-sdk ?
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview ?
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Nov 26 '25 21:11 codecov[bot]

I think we can still merge this PR, since it will trigger publish_tool.yaml to publish a new version of the codegen image. We can then update the Makefile and gen.yaml image in a later PR. What do you think, @khanhtc1202?

Or, we could update the image and use the new one in this PR, but I don’t think I have write access to push a new image version.

niladrix719 avatar Dec 09 '25 17:12 niladrix719

@niladrix719 Since the codegen check is a required step in the CI, I think it's better to fix the broken CI first 👀

khanhtc1202 avatar Dec 17 '25 07:12 khanhtc1202

okay can you help me publish the new image, so I can use it here

niladrix719 avatar Dec 17 '25 08:12 niladrix719