pipecd icon indicating copy to clipboard operation
pipecd copied to clipboard
verified publisher icon pipe-cd

Remove long time deprecated features from codebase (prepare for pipecd-v1 release)

Open khanhtc1202 opened this issue 6 months ago • 3 comments

What would you like to be added:

As preparation for PipeCD v1 release (scheduled in the end of this year), I want to clean up the codebase. As the result of this issue, features marked as deprecated would be:

  • Deleted from the codebase (controlplane codebase)
  • Has a clear decision that whether we bring that feature to the v1 codebase or not

This issue will be used to track the progress of deprecated features removal.

Note: The deprecated feature on pipedv0 could be remained in pipedv0 codebase, and will not be included in pipedv1.

Why is this needed:

khanhtc1202 avatar Jun 19 '25 02:06 khanhtc1202

Features/Configurations marked as deprecated:

  • [ ] FileDB (https://github.com/pipe-cd/pipecd/issues/5652)
  • [x] EnableDefaultKubernetesCloudProvider config in piped (ref: https://github.com/pipe-cd/pipecd/blob/master/pkg/app/piped/cmd/piped/piped.go#L148)
  • [ ] EventWatcher config via .pipe/ directory (ref: https://pipecd.dev/docs-v0.52.x/user-guide/event-watcher/#use-the-pipe-directory)
  • [x] SaveDeploymentMetadata in piped/service.proto (ref: https://github.com/pipe-cd/pipecd/blob/master/pkg/app/server/service/pipedservice/service.proto#L90C9-L90C31)
  • [x] Platform(XXX)Input.AutoRollback (ref: https://github.com/pipe-cd/pipecd/blob/master/pkg/config/application_ecs.go#L67-L68)
  • [ ] App config NotificationMention.slack (ref: https://pipecd.dev/docs-v0.52.x/user-guide/configuration-reference/#notificationmention)
  • [x] Piped config CloudProviders/PlatformProvider (except for deployment metrics collector)
  • [ ] Piped config Notifications.Receivers.Slack.OAuthToken (ref: https://pipecd.dev/docs-v0.52.x/user-guide/managing-piped/configuration-reference/#notificationreceiverslack)
  • [ ] All KindPlatform in the application config other than KindApplication
  • [x] pipectl init command (ref: https://github.com/pipe-cd/pipecd/issues/4677) -> https://github.com/pipe-cd/pipecd/pull/5958
  • [ ] TBD

Model / Internal:

  • [ ] Model ArtifactVersion.Kind (ref: https://github.com/pipe-cd/pipecd/blob/master/pkg/model/common.proto#L95-L96)
  • [ ] Model Deployment.Metadata (ref: https://github.com/pipe-cd/pipecd/blob/master/pkg/model/deployment.proto#L105-L106)
  • [x] Model PipelineStage.predefined (ref: https://github.com/pipe-cd/pipecd/blob/master/pkg/model/deployment.proto#L150-L151)
  • [x] Model PipelineStage.visible (ref: https://github.com/pipe-cd/pipecd/blob/master/pkg/model/deployment.proto#L153-L154) -> https://github.com/pipe-cd/pipecd/pull/5971
  • [ ] TBD

khanhtc1202 avatar Jun 19 '25 06:06 khanhtc1202

can i work on it EventWatcher config via .pipe/ directory ? We are going to remove this fully from Piped, right? @khanhtc1202

sagnik3788 avatar Aug 27 '25 21:08 sagnik3788

@sagnik3788 That feature is under discussion since our users currently prefer that over the in-application event watcher configuration, due to it compatibility with multiple application projects. So I think we would like to keep it for pipedv1

khanhtc1202 avatar Sep 02 '25 13:09 khanhtc1202