pipecd icon indicating copy to clipboard operation
pipecd copied to clipboard

Redux replace events page

Open hongky-1994 opened this issue 6 months ago • 1 comments

What this PR does:

  • This MR depends on https://github.com/pipe-cd/pipecd/pull/5915
  • remove redux modules/event
  • add query for get event infinites
  • Update test

Why we need it:

  • remove redux module from event page

Which issue(s) this PR fixes:

Partof #5868

Does this PR introduce a user-facing change?: no

  • How are users affected by this change: no
  • Is this breaking change: no
  • How to migrate (if breaking change): no

hongky-1994 avatar Jun 09 '25 03:06 hongky-1994

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 28.20%. Comparing base (69ce763) to head (5f25fb6). Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5928      +/-   ##
==========================================
- Coverage   28.21%   28.20%   -0.02%     
==========================================
  Files         520      520              
  Lines       56046    56046              
==========================================
- Hits        15814    15808       -6     
- Misses      38980    38986       +6     
  Partials     1252     1252              
Flag Coverage Δ
. 23.21% <ø> (-0.02%) :arrow_down:
.-pkg-app-pipedv1-plugin-kubernetes 66.44% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.33% <ø> (ø)
.-pkg-app-pipedv1-plugin-terraform 80.26% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-plugin-sdk 50.71% <ø> (ø)
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 09 '25 03:06 codecov[bot]

@hongky-1994 I found that the difference in behavior between the demo.pipecd.dev, and this fix. Filtering events by status appears to reset the state. Could you check it?

  1. On the demo.pipecd.dev

https://github.com/user-attachments/assets/4e8bc0b9-b02a-46f5-8ca2-562c0bfbbb63

  1. On this fix

https://github.com/user-attachments/assets/1287d343-d016-403f-8490-763d99f5584e

ffjlabo avatar Jul 08 '25 01:07 ffjlabo

Thanks @ffjlabo , I have update the code to keep the minUpdatedAt like the demo.pipe.dev . Please review it again . Thank you so much.

https://github.com/user-attachments/assets/88e5afb1-a1b2-46e5-a0f9-38e931cd7b36

hongky-1994 avatar Jul 09 '25 07:07 hongky-1994