pipecd icon indicating copy to clipboard operation
pipecd copied to clipboard

Remove Redux in Insight page

Open hongky-1994 opened this issue 7 months ago • 1 comments

What this PR does:

  • This MR depends on !5893
  • remove redux modules/insight
  • remove redux modules/deployment-change-failure-rate
  • remove redux modules/deployment-frequency
  • add query for insight
  • add query for app list , piped list
  • add toast messages context
  • update query provider with error handler show toast

Why we need it:

  • remove redux module from insight page

Which issue(s) this PR fixes:

Partof #5868

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

hongky-1994 avatar Jun 03 '25 18:06 hongky-1994

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 28.16%. Comparing base (fdb9066) to head (dfc1e0d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5915   +/-   ##
=======================================
  Coverage   28.16%   28.16%           
=======================================
  Files         516      516           
  Lines       55895    55895           
=======================================
  Hits        15743    15743           
  Misses      38900    38900           
  Partials     1252     1252           
Flag Coverage Δ
. 23.22% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 66.42% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.51% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-plugin-sdk 50.89% <ø> (ø)
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 03 '25 18:06 codecov[bot]

@hongky-1994 I have two questions about this PR. Could you check them?

1. Applications by piped show the different values for the two cases below. Is this related to the fix in this PR?

  • The view on the local with the current PR branch PipeCD

  • The view on https://demo.pipecd.dev/insights?project=dev PipeCD

2. On my local check, I found the icon like the image below. Is it for development mode? PipeCD

When clicking the icon, we can see something like the image below. PipeCD

ffjlabo avatar Jun 27 '25 16:06 ffjlabo

Thanks @ffjlabo

  1. Applications by piped show the different values for the two cases below. Is this related to the fix in this PR?
  • My mistake, I have updated the code to not count deleted apps. The applications by piped should not count deleted app.
  1. On my local check, I found the icon like the image below. Is it for development mode? Yes it is only on development. It is the react-query devtools support view cache and query state of react-query. In production mode it will be hidden.

CleanShot 2025-06-28 at 09 02 32

hongky-1994 avatar Jun 28 '25 02:06 hongky-1994

@hongky-1994 Thank you for checking, LGTM!

ffjlabo avatar Jun 30 '25 01:06 ffjlabo

@khanhtc1202 Sorry, plz re-approve

ffjlabo avatar Jun 30 '25 01:06 ffjlabo