pipecd icon indicating copy to clipboard operation
pipecd copied to clipboard

expose stage info created by buildpipeline phase to executestage phase. add null check for getDeploymentPluginMetadata

Open hiep-tk opened this issue 7 months ago • 1 comments

What this PR does: as title

Why we need it: currently the script_run stages need more context to publish their stage already run status to the script_run_rollback so multiple rollbacks can be differentiated and selectively run

Which issue(s) this PR fixes: Part of #5901

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

hiep-tk avatar Jun 02 '25 06:06 hiep-tk

Codecov Report

Attention: Patch coverage is 32.75862% with 117 lines in your changes missing coverage. Please review.

Project coverage is 54.90%. Comparing base (b7555ad) to head (f9530e1). Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/pipedv1/plugin/scriptrun/plugin.go 32.88% 97 Missing and 3 partials :warning:
pkg/app/pipedv1/plugin/scriptrun/options.go 43.75% 6 Missing and 3 partials :warning:
pkg/app/pipedv1/plugin/scriptrun/main.go 0.00% 8 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5910       +/-   ##
===========================================
+ Coverage   28.23%   54.90%   +26.67%     
===========================================
  Files         512       90      -422     
  Lines       55326     8771    -46555     
===========================================
- Hits        15620     4816    -10804     
+ Misses      38461     3625    -34836     
+ Partials     1245      330      -915     
Flag Coverage Δ
. ?
.-pkg-app-pipedv1-plugin-kubernetes 66.42% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.51% <ø> (ø)
.-pkg-app-pipedv1-plugin-scriptrun 32.36% <32.36%> (?)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-plugin-sdk 50.92% <100.00%> (+0.02%) :arrow_up:
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (?)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 02 '25 07:06 codecov[bot]

@hiep-tk Let's restart as a new PR!

t-kikuc avatar Jul 02 '25 07:07 t-kikuc