pipecd icon indicating copy to clipboard operation
pipecd copied to clipboard

Install react query v4 and add auth context

Open hongky-1994 opened this issue 7 months ago • 3 comments

What this PR does:

  • Install react query v4
  • Add Auth Context
  • Remove redux module/me

Why we need it:

  • AuthContext to replace module/me in redux storage.
  • We use react query v4 instead of v5 due to dependency conflict. React-Query v5 only support react 18+, whereas v4 is support for react 16.8+ which is more suitable for our current setting (react 17).

Which issue(s) this PR fixes:

Partof #5868

Does this PR introduce a user-facing change?: no

  • How are users affected by this change: no
  • Is this breaking change: no
  • How to migrate (if breaking change): no

hongky-1994 avatar May 28 '25 16:05 hongky-1994

@hongky-1994 Thank you for your contribution! We look forward to seeing more from you. Please run the make check command to ensure your changes will pass the CI. After successfully running the command on your local machine, the instructions will be printed out. Please follow them to commit your changes. If the check has not passed, please fix the issues and push the changes to your branch. Then, please run the make check command again to ensure the issues are fixed.

github-actions[bot] avatar May 28 '25 16:05 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 28.15%. Comparing base (aaed1ad) to head (92367a3). Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5893   +/-   ##
=======================================
  Coverage   28.15%   28.15%           
=======================================
  Files         518      518           
  Lines       55909    55909           
=======================================
  Hits        15743    15743           
  Misses      38914    38914           
  Partials     1252     1252           
Flag Coverage Δ
. 23.22% <ø> (ø)
.-pkg-app-pipedv1-plugin-example 0.00% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 66.42% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.51% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-plugin-sdk 50.89% <ø> (ø)
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar May 28 '25 16:05 codecov[bot]

Sorry, we updated the CI and branch protection rules. I updated the branch of this PR by pushing the Update branch button, which is the GitHub feature. Please let me know if you see any unexpected behavior.

Warashi avatar May 29 '25 03:05 Warashi