pipecd icon indicating copy to clipboard operation
pipecd copied to clipboard
verified publisher icon pipe-cd

Add option --dependency-update to the command helm template

Open golemiso opened this issue 7 months ago • 6 comments

What this PR does: Update dependencies if they are missing before installing the chart

Why we need it: To deploy remote helm charts which have dependencies

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Almost Never: Doc says this option works only when you have missing dependencies. https://helm.sh/docs/helm/helm_template/

  • How are users affected by this change: None
  • Is this breaking change: No
  • How to migrate (if breaking change): None

golemiso avatar May 27 '25 02:05 golemiso

@golemiso Thank you for your contribution! We look forward to seeing more from you. Please run the make check command to ensure your changes will pass the CI. After successfully running the command on your local machine, the instructions will be printed out. Please follow them to commit your changes. If the check has not passed, please fix the issues and push the changes to your branch. Then, please run the make check command again to ensure the issues are fixed.

github-actions[bot] avatar May 27 '25 02:05 github-actions[bot]

make check failed due to an old commit 3c2caa059a3be7ef92558a804daf00436766a442

./hack/ensure-dco.sh
Error: Commit 3c2caa059a3be7ef92558a804daf00436766a442 is missing Signed-off-by line
Please run 'git rebase --signoff 3c2caa059a3be7ef92558a804daf00436766a442~1' to fix it

Could you help me fixing this ?

golemiso avatar May 27 '25 08:05 golemiso

@golemiso Sorry for the inconvenience. It may come from your origin/master being too old. Could you please update it to the current upstream master branch and retry the make check? https://github.com/pipe-cd/pipecd/blob/1e1e9c4810a4b50ddac1f97d0d76f1246172e7b3/hack/ensure-dco.sh#L21

Warashi avatar May 27 '25 08:05 Warashi

/check-commit 80923622a75523f225194eb11e6522f940eed8a52b0f5d38f715165192151a51

golemiso avatar May 28 '25 01:05 golemiso

@golemiso The check has passed. Thank you for your contribution!

github-actions[bot] avatar May 28 '25 01:05 github-actions[bot]

Sorry, we updated the CI and branch protection rules. I updated the branch of this PR by pushing the Update branch button, which is the GitHub feature. Please let me know if you see any unexpected behavior.

Warashi avatar May 29 '25 03:05 Warashi