pipecd icon indicating copy to clipboard operation
pipecd copied to clipboard

[feat] : Add support for token and certificate authentication in Helm chart registry

Open kirat10x opened this issue 7 months ago • 6 comments

What this PR does:

Why we need it:

Which issue(s) this PR fixes:

Fixes #3743

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Reference

kirat10x avatar May 16 '25 06:05 kirat10x

@kiratlog Please fix build, lint, test

t-kikuc avatar May 16 '25 08:05 t-kikuc

It's a work in progress; I have some local changes and will push them upstream.

kirat10x avatar May 16 '25 15:05 kirat10x

@kiratlog Thank you for the PR. At first, we need to clarify the authentication method for the helm chart registry. Could you investigate it more, other than basic authentication? If possible, it would be nice to have the usage for other methods.

ffjlabo avatar May 19 '25 03:05 ffjlabo

all the supported login method by helm.

https://helm.sh/docs/helm/helm_registry_login/

kirat10x avatar May 22 '25 08:05 kirat10x

@kiratlog

Thank you for your investigation.

I read the document, and your implementation uses the options written on that document. I want to try your implementation on some platforms to confirm it works. Could you let me know which platform you have checked the implementation works on?

Warashi avatar May 22 '25 08:05 Warashi

Sorry, we updated the CI and branch protection rules. I updated the branch of this PR by pushing the Update branch button, which is the GitHub feature. Please let me know if you see any unexpected behavior.

Warashi avatar May 29 '25 03:05 Warashi

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Jun 29 '25 00:06 github-actions[bot]

This PR was closed because it has been stalled for 7 days with no activity. Feel free to reopen if still applicable.

github-actions[bot] avatar Jul 07 '25 00:07 github-actions[bot]