pipecd icon indicating copy to clipboard operation
pipecd copied to clipboard

Remove deprecated field from Deployment

Open sagnik3788 opened this issue 8 months ago • 6 comments

What this PR does: as title

Why we need it: version field was already marked as deprecated and is no longer in use

Which issue(s) this PR fixes:

Fixes #5061

sagnik3788 avatar May 11 '25 02:05 sagnik3788

@sagnik3788 Hi, please execute make gen/code to fix https://github.com/pipe-cd/pipecd/actions/runs/14951420716/job/42007019300?pr=5809

t-kikuc avatar May 12 '25 01:05 t-kikuc

I will fix these

sagnik3788 avatar May 13 '25 20:05 sagnik3788

@sagnik3788 Please fix lint and test, and use make gen/code

t-kikuc avatar May 16 '25 08:05 t-kikuc

@sagnik3788 And please fix the conflict 🙇 It's due to other PRs.

t-kikuc avatar May 22 '25 03:05 t-kikuc

Sorry, we updated the CI and branch protection rules. I updated the branch of this PR by pushing the Update branch button, which is the GitHub feature. Please let me know if you see any unexpected behavior.

Warashi avatar May 29 '25 03:05 Warashi

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 36.28%. Comparing base (44a0c00) to head (7bf88c4). Report is 46 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5809      +/-   ##
==========================================
+ Coverage   27.85%   36.28%   +8.43%     
==========================================
  Files         519       30     -489     
  Lines       55793     3296   -52497     
==========================================
- Hits        15539     1196   -14343     
+ Misses      39070     2034   -37036     
+ Partials     1184       66    -1118     
Flag Coverage Δ
. ?
.-pkg-app-pipedv1-plugin-example 0.00% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes ?
.-pkg-app-pipedv1-plugin-kubernetes_multicluster ?
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-plugin-sdk 49.25% <ø> (ø)
.-tool-actions-gh-release 19.58% <ø> (ø)
.-tool-actions-plan-preview 23.22% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar May 29 '25 07:05 codecov[bot]