pipecd icon indicating copy to clipboard operation
pipecd copied to clipboard

[Snyk] Upgrade redux-thunk from 2.4.1 to 2.4.2

Open khanhtc1202 opened this issue 1 year ago • 1 comments

snyk-top-banner

Snyk has created this PR to upgrade redux-thunk from 2.4.1 to 2.4.2.

:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


  • The recommended version is 1 version ahead of your current version.

  • The recommended version was released on 2 years ago.


[!IMPORTANT]

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

khanhtc1202 avatar Aug 07 '24 07:08 khanhtc1202

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 22.79%. Comparing base (34363a8) to head (a83947d). Report is 47 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5117   +/-   ##
=======================================
  Coverage   22.78%   22.79%           
=======================================
  Files         412      412           
  Lines       43863    43827   -36     
=======================================
- Hits         9996     9990    -6     
+ Misses      33080    33050   -30     
  Partials      787      787           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 07 '24 07:08 codecov[bot]

I want to close this PR.

The reasons are below.

  • lint/web trapped with a type check issue
    • The type ThunkAction has a workaround in the issue comments.
    • The type AsyncThunkAction has no workaround, so we cannot fix it.
  • The difference between v2.4.1 and v2.4.2 is very small, and there is no strong reason to keep up its version.

WDYT? @khanhtc1202 @t-kikuc @ffjlabo

Warashi avatar Sep 04 '24 06:09 Warashi

I'm okay with close this PR 👍

khanhtc1202 avatar Sep 04 '24 06:09 khanhtc1202

I agree, this PR does not contain important fixes.

t-kikuc avatar Sep 04 '24 06:09 t-kikuc