pipecd icon indicating copy to clipboard operation
pipecd copied to clipboard

Support `commitMatcher` for app kinds other than K8sApp

Open t-kikuc opened this issue 1 year ago • 1 comments

What would you like to be added:

Support commitMatcher for CloudRunApp, TerraformApp, ECSApp, and LambdaApp.

Why is this needed:

Currently, commitMatcher is only supported for K8sApp as below:

  • K8sApp: https://github.com/pipe-cd/pipecd/blob/812907842c79b6c26f48fc56cf533d9a47cc24a2/pkg/app/piped/planner/kubernetes/kubernetes.go#L166-L196

  • ECSApp: does not have such logic. (CloudRun, Lambda, Terraform too) https://github.com/pipe-cd/pipecd/blob/master/pkg/app/piped/planner/ecs/ecs.go

[IMO] Such logic should be placed in the common planner.go, not platform-specific files.

t-kikuc avatar Jun 12 '24 02:06 t-kikuc

I found the docs is correct. commitMatcher exists only in KubernetesApp

image image

t-kikuc avatar Jun 12 '24 02:06 t-kikuc

Support it on the pipedv1.

ffjlabo avatar Oct 04 '24 08:10 ffjlabo