Use repository settings from piped config
What this PR does / why we need it:
- planner/scheduler should follow repository settings in piped config.
- plan preview builder should not check
RemoteandBranchbecause repository settings in app config metadata are not reliable (they can be outdated by modifying piped config)
Which issue(s) this PR fixes:
Fixes #4618
Does this PR introduce a user-facing change?:
- How are users affected by this change: None
- Is this breaking change: No
- How to migrate (if breaking change): None
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 30.82%. Comparing base (
1864cdb) to head (530752a). Report is 117 commits behind head on master.
:exclamation: Current head 530752a differs from pull request most recent head dab442a
Please upload reports for the commit dab442a to get more accurate results.
Additional details and impacted files
@@ Coverage Diff @@
## master #4739 +/- ##
==========================================
- Coverage 30.84% 30.82% -0.02%
==========================================
Files 222 221 -1
Lines 26037 26011 -26
==========================================
- Hits 8032 8019 -13
+ Misses 17355 17342 -13
Partials 650 650
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thank you for the PR :)
Actually, this change may affect the behavior of executing the pipeline. We need to check and discuss the effect of it. So it may take more time to examine the effect. 🙏
📝 We should investigate the effect because some features including Deployment are based on the information of Application.GtiPath. https://github.com/pipe-cd/pipecd/blob/master/pkg/model/application.pb.go#L110C6-L110C6
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.
refactored: override repository with piped config (decent one) when creating deployment. I suppose this can reduce side effects.
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.
This PR was closed because it has been stalled for 7 days with no activity. Feel free to reopen if still applicable.