pipecd icon indicating copy to clipboard operation
pipecd copied to clipboard

Add helm lint to CI

Open kentakozuka opened this issue 2 years ago • 5 comments

What would you like to be added:

Why is this needed:

kentakozuka avatar Sep 03 '23 23:09 kentakozuka

https://github.com/pipe-cd/pipecd/pull/4587#issuecomment-1704543465 I've mentioned from this issue better if we can have chart testing lint and install

also we can think about KIND Cluster to apply the template by default values and more case if we need to make sure our template is working

hungran avatar Sep 04 '23 03:09 hungran

https://github.com/helm/chart-testing/pull/445 since chart-testing not yet support pulling chart from OCI yet we might need to wait this :) from my opinion, does apply to KIND Cluster during the CI is good enough @kentakozuka @khanhtc1202 wdyt?

hungran avatar Sep 04 '23 03:09 hungran

@hungran Correct me if I was wrong, but none of the charts under /manifests references osc://. So, I am not sure if we have to wait for the PR merged that you address.

kentakozuka avatar Sep 05 '23 02:09 kentakozuka

@kentakozuka sorry for the late response, what I mean is chart testing we can do more than lint we can also try to pull the chart (by chart testing) to make sure it can be pull

hungran avatar Sep 08 '23 14:09 hungran

@hungran sounds cool!

kentakozuka avatar Oct 23 '23 23:10 kentakozuka