pipecd icon indicating copy to clipboard operation
pipecd copied to clipboard

PipeCD doesn't deploy resources with helm hooks

Open knanao opened this issue 2 years ago • 4 comments

What happened:

What you expected to happen:

How to reproduce it:

Environment:

  • piped version:
  • control-plane version:
  • Others:

knanao avatar Dec 23 '22 08:12 knanao

We may need to adopt helm install command to make this available 🤔

khanhtc1202 avatar Apr 14 '23 03:04 khanhtc1202

Ingress NGINX Controller uses Helm hooks to update Admission Webhooks. https://artifacthub.io/packages/helm/ingress-nginx/ingress-nginx#how-the-chart-configures-the-hooks

I would like to see Helm hook support in PipeCD.

daichi-sato-xa avatar Aug 28 '23 07:08 daichi-sato-xa

Hi @daichi-sato-xa, we currently support CUSTOM_SYNC stage, which we can use a kind of helm install command there. So basically, I guess we can use helm hook with PipeCD. Only one point that is remained, which is we can not perform progressive delivery in case of using CUSTOM_SYNC. Would like to have your idea on how do we support helm hook https://pipecd.dev/docs-v0.45.x/user-guide/managing-application/customizing-deployment/custom-sync/

khanhtc1202 avatar Oct 04 '23 03:10 khanhtc1202

Hi @khanhtc1202 , Sorry for the delay in replying.

It seems that Argo CD handles this by mapping Helm hook annotations to Argo CD's own hook annotations. https://argo-cd.readthedocs.io/en/stable/user-guide/helm/#helm-hooks

For example, how about PipeCD also mapping Helm's hook annotations to PipeCD's own annotations and executing them in sequence like a Deployment chain?

daichi-sato-xa avatar Oct 12 '23 06:10 daichi-sato-xa