pipecd icon indicating copy to clipboard operation
pipecd copied to clipboard

Published 20 hours ago • verified publisher icon pipe-cd

Add the names of project rbac role to the role model

Open knanao opened this issue 2 years ago • 3 comments

What this PR does / why we need it: Add the name of project rbac role to the role model to prepare to use the new rbac.

CAUTION: This PR may affect the existing jwt authentication so, I'm glad if you look at this carefully.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

knanao avatar May 25 '22 03:05 knanao

If the user belongs to multi teams, the role of the group defined earlier is applied.

This note confused me a bit. How about merging all group roles, and the strongest one will be applied? I think it would be better for the users.

khanhtc1202 avatar May 26 '22 03:05 khanhtc1202

@khanhtc1202 I thought so too at first but actually, the definition of the strongest one is difficult for the custom RBAC role. That's why I adapted the definition priority of the user groups.

knanao avatar May 26 '22 03:05 knanao

Interesting feature! Is There a Chance for the code review to happen soon ?

rfelgent avatar Aug 02 '22 08:08 rfelgent

Interesting feature! Is There a Chance for the code review to happen soon ?

@rfelgent Hi. Thank you for your comment. Our team is working on this feature right now. Hopefully, we can have it soon.

nghialv avatar Aug 19 '22 04:08 nghialv