pipecd
pipecd copied to clipboard
Parse terraform local module source
What this PR does / why we need it:
This PR changes to show URL for terraform local module. ref: local module https://www.terraform.io/language/modules/sources#local-paths
Which issue(s) this PR fixes:
A part of https://github.com/pipe-cd/pipecd/issues/3303
Does this PR introduce a user-facing change?:
Be able to show URL for terraform local module.
This pull request is NOT APPROVED. It will be approved when one of the following conditions is met:
- Received a comment that contains
/approve
from an approver. - Received approval at review changes UI from at least
1
approvers.
Code coverage for golang is 34.98%
. This pull request increases coverage by 0.04%
.
File | Function | Base | Head | Diff |
---|---|---|---|---|
pkg/app/piped/cloudprovider/terraform/module.go | isModuleLocal | -- |
100.00% |
+100.00% |
pkg/app/piped/cloudprovider/terraform/module.go | NewLocalModuleSourceConverter | -- |
0.00% |
+0.00% |
pkg/app/piped/cloudprovider/terraform/module.go | LocalModuleSourceConverter.MakeURL | -- |
85.71% |
+85.71% |
Code coverage for golang is 34.97%
. This pull request increases coverage by 0.03%
.
File | Function | Base | Head | Diff |
---|---|---|---|---|
pkg/app/piped/cloudprovider/terraform/module.go | isLocalModule | -- |
100.00% |
+100.00% |
pkg/app/piped/cloudprovider/terraform/module.go | NewLocalModuleSourceConverter | -- |
0.00% |
+0.00% |
pkg/app/piped/cloudprovider/terraform/module.go | LocalModuleSourceConverter.MakeURL | -- |
85.71% |
+85.71% |
The following ISSUES will be created once got merged. If you want me to skip creating the issue, you can use /todo skip
command.
Details
1. convert remote module to URL.
https://github.com/pipe-cd/pipecd/blob/4dbe548fc8be6d457544e2d5cfad57e2e27aca53/pkg/app/piped/cloudprovider/terraform/module.go#L118-L121
This was created by todo plugin since "TODO:" was found in https://github.com/pipe-cd/pipecd/commit/4dbe548fc8be6d457544e2d5cfad57e2e27aca53 when #3461 was merged. cc: @ffjlabo.
Code coverage for golang is 35.00%
. This pull request increases coverage by 0.06%
.
File | Function | Base | Head | Diff |
---|---|---|---|---|
pkg/app/piped/cloudprovider/terraform/module.go | isLocalModule | -- |
100.00% |
+100.00% |
pkg/app/piped/cloudprovider/terraform/module.go | NewLocalModuleSourceConverter | -- |
100.00% |
+100.00% |
pkg/app/piped/cloudprovider/terraform/module.go | LocalModuleSourceConverter.MakeURL | -- |
85.71% |
+85.71% |
pkg/app/piped/cloudprovider/terraform/module.go | FindArtifactVersions | 100.00% |
90.91% |
-9.09% |
Nice /lgtm
@ffjlabo Thanks for your great work!
Please feel free to transfer this PR to me. 👍 And let me hold this PR to take a deeper look at this feature.
/hold
/hold
Please create another PR when you'll work on this task.
CLA Assistant Lite bot: Welcome! Thanks for your contributing. It looks like this is your first PR to this repository 🎉. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). Please read the CLA and leave a below comment on this pull request to sign the CLA.
/cla sign
You can retrigger this bot by commenting recheck in this Pull Request