pipecd icon indicating copy to clipboard operation
pipecd copied to clipboard

Parse terraform local module source

Open ffjlabo opened this issue 2 years ago • 8 comments

What this PR does / why we need it:

This PR changes to show URL for terraform local module. ref: local module https://www.terraform.io/language/modules/sources#local-paths

Which issue(s) this PR fixes:

A part of https://github.com/pipe-cd/pipecd/issues/3303

Does this PR introduce a user-facing change?:

Be able to show URL for terraform local module.

ffjlabo avatar Mar 30 '22 03:03 ffjlabo

APPROVE

This pull request is NOT APPROVED. It will be approved when one of the following conditions is met:

  • Received a comment that contains /approve from an approver.
  • Received approval at review changes UI from at least 1 approvers.

pipecd-bot avatar Mar 30 '22 03:03 pipecd-bot

COVERAGE

Code coverage for golang is 34.98%. This pull request increases coverage by 0.04%.

File Function Base Head Diff
pkg/app/piped/cloudprovider/terraform/module.go isModuleLocal -- 100.00% +100.00%
pkg/app/piped/cloudprovider/terraform/module.go NewLocalModuleSourceConverter -- 0.00% +0.00%
pkg/app/piped/cloudprovider/terraform/module.go LocalModuleSourceConverter.MakeURL -- 85.71% +85.71%

pipecd-bot avatar Mar 30 '22 03:03 pipecd-bot

COVERAGE

Code coverage for golang is 34.97%. This pull request increases coverage by 0.03%.

File Function Base Head Diff
pkg/app/piped/cloudprovider/terraform/module.go isLocalModule -- 100.00% +100.00%
pkg/app/piped/cloudprovider/terraform/module.go NewLocalModuleSourceConverter -- 0.00% +0.00%
pkg/app/piped/cloudprovider/terraform/module.go LocalModuleSourceConverter.MakeURL -- 85.71% +85.71%

pipecd-bot avatar Mar 30 '22 09:03 pipecd-bot

TODO

The following ISSUES will be created once got merged. If you want me to skip creating the issue, you can use /todo skip command.

Details

1. convert remote module to URL.

https://github.com/pipe-cd/pipecd/blob/4dbe548fc8be6d457544e2d5cfad57e2e27aca53/pkg/app/piped/cloudprovider/terraform/module.go#L118-L121

This was created by todo plugin since "TODO:" was found in https://github.com/pipe-cd/pipecd/commit/4dbe548fc8be6d457544e2d5cfad57e2e27aca53 when #3461 was merged. cc: @ffjlabo.

pipecd-bot avatar Mar 30 '22 11:03 pipecd-bot

COVERAGE

Code coverage for golang is 35.00%. This pull request increases coverage by 0.06%.

File Function Base Head Diff
pkg/app/piped/cloudprovider/terraform/module.go isLocalModule -- 100.00% +100.00%
pkg/app/piped/cloudprovider/terraform/module.go NewLocalModuleSourceConverter -- 100.00% +100.00%
pkg/app/piped/cloudprovider/terraform/module.go LocalModuleSourceConverter.MakeURL -- 85.71% +85.71%
pkg/app/piped/cloudprovider/terraform/module.go FindArtifactVersions 100.00% 90.91% -9.09%

pipecd-bot avatar Mar 30 '22 11:03 pipecd-bot

Nice /lgtm

knanao avatar Mar 31 '22 05:03 knanao

@ffjlabo Thanks for your great work!

Please feel free to transfer this PR to me. 👍 And let me hold this PR to take a deeper look at this feature.

/hold

nghialv avatar Mar 31 '22 10:03 nghialv

/hold

nghialv avatar Mar 31 '22 10:03 nghialv

Please create another PR when you'll work on this task.

knanao avatar Nov 25 '22 05:11 knanao

CLA Assistant Lite bot: Welcome! Thanks for your contributing. It looks like this is your first PR to this repository 🎉. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). Please read the CLA and leave a below comment on this pull request to sign the CLA.


/cla sign


You can retrigger this bot by commenting recheck in this Pull Request

github-actions[bot] avatar Nov 25 '22 05:11 github-actions[bot]