pipecd icon indicating copy to clipboard operation
pipecd copied to clipboard

Daployment randomly fails with "signal: killed"

Open m-ronchi opened this issue 3 years ago • 3 comments

What happened: kubernetes deployments randomly fail with the following message: Failed to apply manifest: name="***", kind="<***>", namespace="***", apiVersion="apps/v1" (failed to apply: (signal: killed))

it happens randomly, on random manifests (can be Deployment, ConfigMap, Secret, etc...). sometimes it also fails the rollback with the same message. re-triggering a deploy with sync sometimes fixes it

What you expected to happen: consistent deploys

How to reproduce it: happens randomly

Environment:

  • piped version: 0.9.15, but it happened since 0.9.9
  • control-plane version: same
  • Others:

m-ronchi avatar Jun 24 '21 16:06 m-ronchi

@m-ronchi Hi.

Thanks for your report.

Based on the error message "(signal: killed)", I think that your piped pod was terminated during Kubernetes' rescheduling process. (We will improve the error message to make it more understandable.)

Can I have some questions?

  • Did piped pod restart after got that error?
  • The running deployments were resumed after that or you had to re-trigger it manually?

nghialv avatar Jun 25 '21 00:06 nghialv

  • no, the pod continued to run (unrelated, I did manually restart it to try to fix #1934 that happened again). I think. that the kubectl process was killed and piped didn't handle it properly
  • the deployments had failed (and the rollback failed too). when I synced the app manually from the frontend they restarted

I did found an unconstrained pod on the node that was running piped though. still, this kind of non-deterministic failures should be retried, especially when rolling back as it can leave an inconsistent cluster state (on Unix, a killed process has exit code = 128 + [signal number]. you can use that to handle os vs kubectl errors)

m-ronchi avatar Jun 25 '21 08:06 m-ronchi

Hi @m-ronchi, various things have changed since then but hope you go well with PipeCD. Could you confirm the existence of this issue? Is it resolved already?

khanhtc1202 avatar Jan 20 '22 13:01 khanhtc1202

Staled!

khanhtc1202 avatar Apr 14 '23 11:04 khanhtc1202