clean-code-php

clean-code-php copied to clipboard

How to handle un/happy paths

6

``` if (error) unhappy path; happy path; ``` Happy path should not be in a conditional. Would you welcome a PR?

szepeviktor

> Arrays should be used to store lists: keyless elements of the same type. Would you welcome a PR explaining associative arrays should be intelligent objects?

szepeviktor

"Use default arguments instead of short circuiting or conditionals"

2

https://github.com/jupeter/clean-code-php#use-default-arguments-instead-of-short-circuiting-or-conditionals I think, it's must be in "Functions" section and renamed with something like "Don't pass NULL arguments".

danilyer228

odnmalau

Arabic translation

2

thanks for your efforts, I suggest adding the Arabic version of this guide, and I'm ready to do the translation process and add it to the translations list.

Moussabkobisy

reusable value-objects w/ better type safety

4

I didn't really understand the point of traits until recently and now I can't live without them. And since I didn't find anything about traits on here, I wanted to...

sebastianstucke87

Discussion about "Don't add unneeded context"

4

Hi, I would like to bring up a discussion about "[Don't add unneeded context](https://github.com/jupeter/clean-code-php#dont-add-unneeded-context)". I have few considerations why I think this very example is not good and the context...

kenashkov

Question on coupling of static classes

4

I recently stumbled across a problem applying the [Dependency Inversion Principle (DIP)](https://github.com/jupeter/clean-code-php#dependency-inversion-principle-dip) trying to write classes for communication with either local (`fopen()`) or remote (`fsockopen()`) serial ports. (In the following...

gregor-j

Possibly incorrect: "Zero arguments is the ideal case"

4

In the section "Function arguments (2 or fewer ideally)" it says: "Zero arguments is the ideal case. One or two arguments is ok, and three should be avoided." However, I...

andreobriennz

"Prefer composition over inheritance": Why you don't use traits?

3

You could really add a good multi-inheritance or composition example by mentioning threads. Although they may force a developer to jump into polimorphic tables, they are a great way to...

phackwer