Piotrek

Results 274 comments of Piotrek

@jeawhanlee Could you update the script and the plugin's branch? @gmetais Thank you! 🥇

Blocking the issue till we have an answer here: https://github.com/wp-media/delay-javascript-loading/pull/32#issuecomment-1260857280

@Mai-Saad I think we're okay here. That's a small and edgy case.

@daigo75 thank you for creating the issue. Could you check if `PHP8.x` is available on the server while WordPress is using `PHP7.x`?

Potentially related issue: https://github.com/wp-media/wp-rocket/issues/5306

@Tabrisrp Your feedback here would be very valuable, could you take a look?

@Tabrisrp What do you think about reducing the size here: https://github.com/wp-media/wp-rocket/blob/c6b74a8ad463158511a7d10352554379d4731099/inc/Engine/Optimization/RUCSS/Database/Tables/UsedCSS.php#L68 That's what @engahmeds3ed suggested at some point, not sure if that works and which option is better/cleaner.

From what I can see, we should not expect this value to be long: ![image](https://user-images.githubusercontent.com/26767037/190167120-f37ff95a-4185-4212-868b-b3660d7ceec9.png)

Since it's scheduled for 3.12.2 we have some time for discussion. ``` making this an index instead of the status column. ``` Which queries would take advantage of this change?...

@DahmaniAdame Created separate issue about this enhancement: https://github.com/wp-media/wp-rocket/issues/5428