closeable-map icon indicating copy to clipboard operation
closeable-map copied to clipboard

Request for comments: `java.io.{Throwable,Error,Exception}`, `clojure.lang.ExceptionInfo`?

Open piotr-yuxuan opened this issue 2 years ago • 1 comments

Currently closeable-map tries very hard to swallow everything, and as such uses the apex class java.io.Throwable in order to make completely sure errors truly are silent. This is opinionated. Is it a sane default? Why choose another better default? Perhaps this behaviour could be dynamically tuned according to the user's whishes?

Example: https://github.com/piotr-yuxuan/closeable-map/blob/0bbba170992eb1bda05fa7c71da08e76e1a5e6b9/src/piotr_yuxuan/closeable_map.clj#L589

This kind of change would break the API as a matter of course, and would trigger version 1.0.0.

piotr-yuxuan avatar Mar 21 '22 12:03 piotr-yuxuan

However, user can still make use of ::closeable-map/ex-handler to handle exception happening when closing a map. That should be enough, but I'll leave open for some more time.

piotr-yuxuan avatar Sep 17 '22 08:09 piotr-yuxuan