piotr-s-brainhub

@bobthekingofegypt If you know how to fix that, I invite you to open a PR. I also invite you to like this issue (👍) so more 👍it has, it's more...

@mhatvan I don't understand your question clearly. For me it's obvious, `onChange` should be called with the value of the `value` props.

IMO it should still work even without `onChange` being set but maybe `console.warn` would be good. I'll confirm that with my team.

An example applicable in the docs: ``` ```

However, without the `value` set, I get the same error, and even when I define `onChange`, I get this error.

@vi-nastya Thanks for reporting this. I guess we haven't noticed this before because almost nobody uses a carousel with only 2 slides. However, IMO it's worth to be fixed. You're...

@PiotrSzlagura It seems to be a bug. Thanks for reporting. Maybe we'll fix that but your PR will be more than welcome.

@PiotrSzlagura We decided to improve your PR. Or maybe you could do that but you need to consult that with @RobertHebel and @humbak .

@PiotrSzlagura IMO `slidesPerPage` should be always an integer.

@PiotrSzlagura So I'm OK with that, it can be a non-integer.