pioneer icon indicating copy to clipboard operation
pioneer copied to clipboard

Music tracks will be played continuously while game speed is set to paused

Open Max5377 opened this issue 9 months ago • 6 comments

MusicPlayer will now continue to play tracks while game is paused, instead of playing one track and get silenced until unpaused. Edit: rebase. Edit2: rebase.

Max5377 avatar Oct 10 '23 12:10 Max5377

Maybe fade out the music upon pause, and fade in when unpaused?

bszlrd avatar Oct 10 '23 16:10 bszlrd

@nozmajner I meant that this happenes when you set your game speed to pause, I can change description to clarify more. But I suppose this can be added, maybe in the other PR? Edit: Sorry, already stated that. But I think this feature can be added in the pause menu.

Max5377 avatar Oct 10 '23 16:10 Max5377

Oh sorry, I thought it is a report, not a PR

bszlrd avatar Oct 10 '23 16:10 bszlrd

It's not obvious to me that game music should keep playing in paused mode. (What if you paused because your boss is walking towards your computer, when you're sneakily playing pioneer waiting for your work code to compile?)

impaktor avatar Oct 12 '23 13:10 impaktor

@impaktor Well... https://youtu.be/CEvzFcqKbXw?feature=shared&t=13

Some thoughts about it:

  1. Make music continue to play, but at the volume of 0 or just get really quiet (10-25% of current volume);
  2. Music stops to play completely, with sound indication (like clock sound in Sims 3 or maybe some wind sound).

Max5377 avatar Oct 12 '23 15:10 Max5377

Lest we forget this PR; @WKFO do you have any objections to this?

impaktor avatar Mar 02 '24 07:03 impaktor