pioneer icon indicating copy to clipboard operation
pioneer copied to clipboard

Initial support for the XDG folder specification

Open Jummit opened this issue 1 year ago • 2 comments

Initial stab at #4392

Instead of splitting up the contents of the user folder to fully support the XDG spec, this pull request just puts everything in XDG_DATA_HOME if no .pioneers folder exists.

Tested on Linux only.

Jummit avatar Sep 05 '22 21:09 Jummit

Your commit message says XDG_DATA_HOME, the commit itself says XDG_STATE_HOME, so that's already a problem.

The spec says that XDG_STATE_HOME is for data that is "not important", I can't really see the savestates falling into this category. So XDG_DATA_HOME would make more sense.

pcercuei avatar Sep 07 '22 17:09 pcercuei

Your commit message says XDG_DATA_HOME, the commit itself says XDG_STATE_HOME, so that's already a problem.

The spec says that XDG_STATE_HOME is for data that is "not important", I can't really see the savestates falling into this category. So XDG_DATA_HOME would make more sense.

Sorry for that oversight, it's fixed now.

Jummit avatar Sep 07 '22 18:09 Jummit

Sorry about the very long wait time on getting this PR reviewed and approved. When the above changes are implemented, I believe this PR is ready to be merged!

Web-eWorks avatar Nov 06 '22 02:11 Web-eWorks

Sorry about the very long wait time on getting this PR reviewed and approved. When the above changes are implemented, I believe this PR is ready to be merged!

No problem! I've implemented the mentioned changes, let me know if there are any problems, I haven't used C++ in a long time.

Jummit avatar Nov 06 '22 11:11 Jummit