pioneer icon indicating copy to clipboard operation
pioneer copied to clipboard

Themisto mass problem in Sol

Open macksting opened this issue 6 years ago • 6 comments

Observed behaviour

Game attempted and failed to produce a flawless Themisto, presumably the moon of Jupiter

import [modules/TradeShips.lua]: modules/TradeShips.lua did not return anything
GalaxyGenerator::Init()
Creating new galaxy generator 'legacy' version 1
Error: Custom system definition: Value cannot be negative/zero (0.000000) for Themisto : mass
Number of factions added: 103
StarSystemCache: misses: 0, slave hits: 0, master hits: 0
SectorCache: misses: 101, slave hits: 0, master hits: 2

Expected behaviour

Themisto should have non-zero/negative mass or be somehow spawned anyway

Steps to reproduce

Start game, read terminal text

My pioneer version (and OS): build: git (8600607) on Lubuntu 16.04

macksting avatar Apr 08 '18 17:04 macksting

The root problem is that Themisto is so small that it's not represented as a non-zero mass in 32.32 fixed point earth masses. Zero-mass objects generally do work fine though, even as reference frames: Space stations are all zero-mass, for example.

Last time I checked, Themisto was still spawned (with zero mass). Is this the case, or is it missing now?

jaj22 avatar Apr 09 '18 16:04 jaj22

I think they get spawned, it's just a warning to us to fix it (if possible)

fluffyfreak avatar Apr 09 '18 17:04 fluffyfreak

Themisto has got a table value for its mass - no such message any more, fixed

Bodasey avatar Jan 23 '21 11:01 Bodasey

Sol has not been edited since this issue was opened, (except removing rings on all planets except Saturn).

@jaj22 added mass in 2017

		:mass(f(115,1000000000000)) -- 6.9e14 kg, 1.15e-10 EM

(the OP is playing on 20181127_test build)

It's not clear to me what fixed it, (if it is fixed).

impaktor avatar Jan 25 '21 10:01 impaktor

Anyway, why has one chosen this 8km rock to be in the basic version of our solar system, and why has it to stay? (While round moons of Saturn, Mimas and Enkelados, and Eris are not in there, o.k., as long as intra-system commissions are limited to 20AU, you can even remove Neptune.

Bodasey avatar Nov 15 '23 16:11 Bodasey

@Bodasey It's there because someone added it, probably because some article / news motivated someone to add it.

I've always thought it strange that Sol has a bunch of stuff that no other system has, simply because we know it's there. Solution to my complaint was to make all other systems as detailed. However, that has not happened. I will not lament removing small rocks and stuff from Sol.

impaktor avatar Nov 15 '23 17:11 impaktor