webrtc icon indicating copy to clipboard operation
webrtc copied to clipboard

Add PayloadToMimeType map to StreamInfo

Open 5ur3 opened this issue 6 months ago • 5 comments

https://github.com/pion/interceptor/pull/346

5ur3 avatar Jul 08 '25 10:07 5ur3

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 63.16%. Comparing base (4c1af4c) to head (801af07). :warning: Report is 27 commits behind head on master.

:exclamation: There is a different number of reports uploaded between BASE (4c1af4c) and HEAD (801af07). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (4c1af4c) HEAD (801af07)
go 2 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3175       +/-   ##
===========================================
- Coverage   78.03%   63.16%   -14.87%     
===========================================
  Files          93       72       -21     
  Lines       11769     4697     -7072     
===========================================
- Hits         9184     2967     -6217     
+ Misses       2074     1572      -502     
+ Partials      511      158      -353     
Flag Coverage Δ
go ?
wasm 63.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jul 08 '25 10:07 codecov[bot]

Thanks for reviewing it, is it possible to change the member in StreamInfo so it would fit? For example:

  • Add a member that would contain only payload type and mime type (minimum amount of redundant information needed for RED FEC decoder interceptor implementation)
  • Store negotiated codecs information in private field and make a getter method: StreamInfo.GetCodecForPayloadType(uint8) (RTPCodecParameters, error)

Or maybe it can be merged if I provide an example of using this new StreamInfo API by contributing RED FEC decoder interceptor to pion/interceptor/pkg/?

5ur3 avatar Jul 08 '25 12:07 5ur3

Add a member that would contain only payload type and mime type (minimum amount of redundant information needed for RED FEC decoder interceptor implementation)

This sound like a good call, we should only add the information that we need, We might need to refactor streaminfo by the next major version anyways so it contains a slice of codec values.

JoTurk avatar Jul 08 '25 13:07 JoTurk

@JoeTurki Is this better? I have replaced the Codecs field with the PayloadToMimeType map

5ur3 avatar Jul 08 '25 14:07 5ur3

@JoeTurki Is this better? I have replaced the Codecs field with the PayloadToMimeType map

I like this more, but maybe we need to explain what it's doing in the code or maybe rename it to something more readable, not sure what will work best, but as of right now for someone reading the code they might have hard time understanding what it's actually doing!

JoTurk avatar Jul 11 '25 18:07 JoTurk