Add Advertising / Reading ICE trickle support
Description
Figured I'd try my hand at dealing with this. I'll be honest and say I don't FULLY understand what this is for, since pion already supports trickle ICE, but since this IS part of the spec, might as well.
This is nowhere near done (I will also have to do a pull request to the SDP repo to finish the feature), but I do have some questions
-
[x] the "a=ice-options:tickle" seem to be related to ice2? Whatever that is (see https://datatracker.ietf.org/doc/html/rfc9725#section-4.3.3) ~~Does that mean I have to tack on ice2 to the attribute?~~ Resolved, it just tells us what version of ICE we are using https://github.com/pion/webrtc/issues/2898#issuecomment-2800142318
-
[x] how exactly would i add the attribute? I guess I just add a constant here and be done with it https://github.com/pion/sdp/blob/c395deb80b693c4a4f5b28d1ce435f27fa2bc40e/jsep.go#L14
Reference issue
Fixes https://github.com/pion/webrtc/issues/2898
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 84.05%. Comparing base (71b8a13) to head (c736355).
:warning: Report is 1 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #3097 +/- ##
==========================================
- Coverage 84.07% 84.05% -0.03%
==========================================
Files 80 80
Lines 9076 9080 +4
==========================================
+ Hits 7631 7632 +1
- Misses 1023 1025 +2
- Partials 422 423 +1
| Flag | Coverage Δ | |
|---|---|---|
| go | 84.05% <100.00%> (-0.03%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
I think this is ready to be reviewed, pretty sure this is the api changes needed
@ValorZard do you want to merge this for v5.2 or should it wait for the next release?
Uh... im down either way
@ValorZard Okay, Cool, thank you, I'll update this and get it ready for 5.2.