webrtc icon indicating copy to clipboard operation
webrtc copied to clipboard

WIP: simplify interface to TWCC 4/4

Open jech opened this issue 11 months ago • 1 comments

This is part 4/4 of a cross-repository series.

Part 1 is https://github.com/pion/interceptor/pull/297 Part 2 is https://github.com/pion/webrtc/pull/3002 Part 3 is https://github.com/pion/interceptor/pull/298

Please don't merge until I've had a chance to test it in Galene.

@Sean-Der Please let me know if you agree with the principle, so I can start working on making Galene use this interface. Even if you approve, I won't merge until I've convinced myself that it works for Galene.

jech avatar Jan 13 '25 15:01 jech

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.68%. Comparing base (f2191fb) to head (ef9a579). Report is 78 commits behind head on master.

:exclamation: There is a different number of reports uploaded between BASE (f2191fb) and HEAD (ef9a579). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (f2191fb) HEAD (ef9a579)
go 2 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3003       +/-   ##
===========================================
- Coverage   77.77%   63.68%   -14.10%     
===========================================
  Files          89       67       -22     
  Lines       10578     3957     -6621     
===========================================
- Hits         8227     2520     -5707     
+ Misses       1857     1308      -549     
+ Partials      494      129      -365     
Flag Coverage Δ
go ?
wasm 63.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jan 13 '25 15:01 codecov[bot]