webrtc icon indicating copy to clipboard operation
webrtc copied to clipboard

add drawio files for examples

Open mohammadne opened this issue 4 years ago • 1 comments

HI @Sean-Der

Summary

adding drawio diagrams for examples

Motivation

it's very useful for better and one-look understanding of examples

Additional context

I'm willing to add this feature for all the examples, please let me know about that and I will create pull-request for them

in order to not increase project size, I only add drawio xml files (each one is text-based and is about 2Kb) and I'm not include rendered files (png, ...).

Thanks :)

mohammadne avatar Oct 28 '21 08:10 mohammadne

Hi @Sean-Der

is there any update about status of the issue ? I have submitted a pull-request

mohammadne avatar Nov 09 '21 07:11 mohammadne

Hi @mohammadne

I really regret that this didn't get in. It was my fault that I didn't do a better job of guiding this PR. I am going to work on this.

Since this PR had started Github added mermaidjs. I started porting to mermaidjs here. I put you as the author.

I started with data-channel, but I am planning on doing them all https://github.com/pion/webrtc/issues/2415. I understand if you are burned out/not interested in working on Pion (you didn't have a great experience). I would love to have you involved on this though!

Sean-Der avatar Feb 11 '23 05:02 Sean-Der