webrtc icon indicating copy to clipboard operation
webrtc copied to clipboard

Fix AddTrack transceiver reuse per W3C specs

Open EdoaLive opened this issue 4 years ago • 6 comments

According to W3C specifications, the transceiver can be reused if "The sender has never been used to send. More precisely, the [[CurrentDirection]] slot of the RTCRtpTransceiver associated with the sender has never had a value of "sendrecv" or "sendonly"". Current implementation does not have CurrentDirection slot, so the flag usedToSend is set on setDirection change. This fixes #1843 and maybe other issues (for us it fixes other two issues when reusing transceiver, eg clients going and coming back to a conference). This has been done on the v2 branch because we currently don't have the resources to switch our software to v3 and test it there. Looking at the source (master) seems this kind of issue is still there.

EdoaLive avatar Jun 30 '21 15:06 EdoaLive

Thank you so much for the fix @EdoaLive !

I will write a test for it and merge to master and v2 in the next couple of days.

Sean-Der avatar Jul 02 '21 16:07 Sean-Der