webrtc icon indicating copy to clipboard operation
webrtc copied to clipboard

improve samplebuilder docs

Open josharian opened this issue 4 years ago • 2 comments

There's no indication of the units for maxLate.

It's not clear what an rtp.Depacketizer is or what a standard one might look like. What is the byte slice arg and what byte slice is it returning? The tests only show a fakeDepacketizer that is a passthrough. In my testing, a passthrough depacketizer works fine. (Should depacketizer by an option? Should it have type func instead of type interface?)

Are Push and Pop safe for concurrent use? If not, what is the intended use? (If you only Pop after Pushing, then it seems like you might lose packets unnecessarily if there is a delay in inbound packets, but maybe I misunderstand.)

josharian avatar Jun 06 '20 19:06 josharian

@josharian can we close this with your PR? or are further improvements necessary?

tarrencev avatar Sep 16 '20 13:09 tarrencev

I’m no longer using pion; I’m happy to let you decide about the best path forward for this issue.

josharian avatar Sep 17 '20 01:09 josharian

The SampleBuilder has gone through lots of changes since this issue, don't believe these apply anymore.

Sean-Der avatar Apr 01 '24 02:04 Sean-Der