turn icon indicating copy to clipboard operation
turn copied to clipboard

Add IPv6 ClientConfig flag

Open hetelek opened this issue 2 years ago • 3 comments

Adds a IPv6 flag to the turn.ClientConfig, which will allow for IPv6 relay support.

https://github.com/pion/ice/pull/462

hetelek avatar Jun 04 '22 03:06 hetelek

@jech

Sean-Der avatar Jun 04 '22 19:06 Sean-Der

Codecov Report

Merging #265 (801873f) into master (a4f7706) will increase coverage by 0.07%. The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #265      +/-   ##
==========================================
+ Coverage   68.05%   68.12%   +0.07%     
==========================================
  Files          38       38              
  Lines        2432     2438       +6     
==========================================
+ Hits         1655     1661       +6     
+ Misses        643      642       -1     
- Partials      134      135       +1     
Flag Coverage Δ
go 68.12% <66.66%> (+0.07%) :arrow_up:
wasm 45.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client.go 71.42% <66.66%> (+0.44%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a4f7706...801873f. Read the comment docs.

codecov[bot] avatar Jun 04 '22 19:06 codecov[bot]

@hetelek could you please explain why this is needed? Why is it not enough to infer the address family from ClientConfig.Conn, using something like:

network := config.Conn.LocalAddr().Network()

This would avoid adding a new API, and would give us more flexibility in the future if we decide that this is not the right approach.

If an explicit field is needed, I'd prefer it to be called Network and to be either a string or an int rather than a simple boolean, in case more values are needed in the future.

jech avatar Jun 08 '22 12:06 jech

This PR gets obsoleted if #276 gets merged.

stv0g avatar Jan 12 '23 21:01 stv0g

#276 has been merged. I therefore close this PR.

stv0g avatar Apr 19 '23 13:04 stv0g