add generic Dockerfile and docker-compose.yml for pion examples/turn-server/simple

[hthetiot]

Description

add generic Dockerfile and docker-compose.yml for pion examples/turn-server/simple

Usage:

git clone https://github.com/pion/turn.git pion-turn cd pion-turn/examples/turn-server/simple docker build -t pion-turn -f Dockerfile . docker run -e REALM="localhost" -e USERS="username=password" -e UDP_PORT="3478" -e PUBLIC_IP="127.0.0.1" -p 3478:3478 pion-turn

Reference issue

Fixes #151

[hthetiot]

Note: I dont use go get and go install because it's too slow due no --depth=1 support and cause use of internal package not allowed

RUN go get github.com/pions/turn RUN go install github.com/pions/turn/cmd/simple-turn

See https://github.com/golang/go/issues/13078#issuecomment-543858784

[stv0g]

Hey @hthetiot,

are you still interested in getting this merged? I would be happy to support you with this PR.

[hthetiot]

Hey @hthetiot,

are you still interested in getting this merged? I would be happy to support you with this PR.

I will look into to PR feedback, Sorry missed the notifications.

[stv0g]

Perfect :) Can you squash your changes into a single commit and fix the commit message at the same time?

Here are the rules the CI checks for the commit message:

The preceding commit message is invalid
it failed 'Separate subject from body with a blank line' of the following checks

* Separate subject from body with a blank line
* Limit the subject line to 50 characters
* Capitalize the subject line
* Do not end the subject line with a period
* Wrap the body at 72 characters

[codecov[bot]]

Codecov Report

Base: 69.18% // Head: 68.65% // Decreases project coverage by -0.54% :warning:

Coverage data is based on head (57852aa) compared to base (d170d2c). Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
- Coverage   69.18%   68.65%   -0.54%     
==========================================
  Files          36       38       +2     
  Lines        1837     2469     +632     
==========================================
+ Hits         1271     1695     +424     
- Misses        440      641     +201     
- Partials      126      133       +7     

Flag	Coverage Δ
go	68.65% <ø> (-0.54%)	:arrow_down:
wasm	45.55% <ø> (+23.29%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
internal/server/util.go	48.86% <0.00%> (-7.02%)	:arrow_down:
internal/allocation/channel_bind.go	60.00% <0.00%> (-6.67%)	:arrow_down:
relay_address_generator_static.go	52.00% <0.00%> (-5.90%)	:arrow_down:
relay_address_generator_none.go	41.17% <0.00%> (-5.50%)	:arrow_down:
internal/ipnet/util.go	45.00% <0.00%> (-5.00%)	:arrow_down:
internal/allocation/allocation.go	82.85% <0.00%> (-3.33%)	:arrow_down:
internal/server/stun.go	76.92% <0.00%> (-3.08%)	:arrow_down:
internal/server/turn.go	59.25% <0.00%> (-2.99%)	:arrow_down:
server_config.go	33.33% <0.00%> (-1.29%)	:arrow_down:
internal/allocation/permission.go	53.84% <0.00%> (-0.70%)	:arrow_down:
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

[stv0g]

Hey @hthetiot,

I squashed your changes. However, in order to merge them you need to grant me push access to your branch. There should be a little checkbox somewhere for you in this PR here..

[hthetiot]

Hey @hthetiot,

I squashed your changes. However, in order to merge them you need to grant me push access to your branch. There should be a little checkbox somewhere for you in this PR here..

Thx for squash, I found that on Mac docker compose up fail due port range (49152-65535) taken on TURN and generally this range of port cause issue in many environments.

Can you hold on PR so I add a short Readme and add custom port range for TURN in env.

If you can point me to a custom TURN port range example with pion that may help.

[stv0g]

Hi @hthetiot

Sure :)

Here is an example TURN server which which binds to a user defined port range: https://github.com/pion/turn/blob/master/examples/turn-server/port-range/main.go

[hthetiot]

Hi @hthetiot

Sure :)

Here is an example TURN server which which binds to a user defined port range: https://github.com/pion/turn/blob/master/examples/turn-server/port-range/main.go

Perfect, I will update example asap.

[stv0g]

Hi @hthetiot,

is there something I can support you with to get this merged?

[hthetiot]

Hi @hthetiot,

is there something I can support you with to get this merged?

Well. I wanted to add dynamic TURN port, I just need more time to do so, if you want I can give you acess to the branch.