sctp icon indicating copy to clipboard operation
sctp copied to clipboard

SACK chunks followed by other chunks are incorrectly handled.

Open ghost opened this issue 4 years ago • 1 comments

Hi,

This is just a curtesy bug report.

You may be aware of webrtc-rs/sctp, which is a 1:1 Rust port of pion/sctp.

Well I just submitted a fix in their codebase that I believe also affects you.

Basically, the handling of SACK chunks as it is written now incorrectly fails when two chunks are buffered inside the same packet. The fix is trivial: just changing a == to a <.

ghost avatar Oct 01 '21 20:10 ghost

Thank you so much @jkauffmann-legion! Really appreciate you took the time to file over here as well :)

I will work on porting that fix

Sean-Der avatar Oct 01 '21 20:10 Sean-Der