sctp icon indicating copy to clipboard operation
sctp copied to clipboard

Added DialAssociation and ListenAssociation

Open backkem opened this issue 4 years ago • 8 comments

These are helpers to easily run SCTP over UDP. Example adapted. I added the Association postfix to keep space for a potential Dial/Listen implementation that directly gives you a Stream.

Relates to #74

TODO:

  • [x] Tag pion/udp after landing CI
  • [ ] Change to SCTP over IP instead of over UDP.
  • [ ] Proper shutdown for the listener.

backkem avatar Jun 20 '20 19:06 backkem

Codecov Report

Merging #126 into master will decrease coverage by 2.39%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
- Coverage   78.62%   76.22%   -2.40%     
==========================================
  Files          43       45       +2     
  Lines        2779     2869      +90     
==========================================
+ Hits         2185     2187       +2     
- Misses        459      548      +89     
+ Partials      135      134       -1     
Flag Coverage Δ
#go 76.22% <0.00%> (-2.40%) :arrow_down:
#wasm 67.82% <0.00%> (-3.57%) :arrow_down:
Impacted Files Coverage Δ
association.go 82.11% <0.00%> (-0.27%) :arrow_down:
chunk_payload_data.go 69.69% <ø> (ø)
dialer.go 0.00% <0.00%> (ø)
listener.go 0.00% <0.00%> (ø)
stream.go 86.28% <0.00%> (-5.23%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6f6d053...0dee1d0. Read the comment docs.

codecov[bot] avatar Jun 20 '20 19:06 codecov[bot]

Playing around with adding Dial and Listen. However, it's not directly clear how to handle the streamIdentifier and defaultPayloadType. We could:

  • Add them to the method signature or config.
  • Somehow encode them into the address urls.
  • Pick a default and only offer that when using these high-level methods. However, it's not clear what defaultPayloadType to pick. Suggestions welcome. I may go with the 3rd option for now and just hardcode PayloadTypeWebRTCDCEP.

backkem avatar Jun 21 '20 09:06 backkem