GCC: Fix bug when transitioning states
The original implementation did not transition rate controller states properly. The initial state of the transition was incorrect because it did not use or record the previous state of the rate controller. This lastState field was available but never used, which indicates that it probably was originally planned for this use case but might have slipped through the cracks during the initial implementation.
See GCC RFC for details.
Description
Reference issue
Fixes #271
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 72.07%. Comparing base (
e187410) to head (577d59e).
Additional details and impacted files
@@ Coverage Diff @@
## master #296 +/- ##
==========================================
+ Coverage 71.31% 72.07% +0.76%
==========================================
Files 80 80
Lines 4483 4484 +1
==========================================
+ Hits 3197 3232 +35
+ Misses 1153 1117 -36
- Partials 133 135 +2
| Flag | Coverage Δ | |
|---|---|---|
| go | 72.07% <100.00%> (+0.89%) |
:arrow_up: |
| wasm | 70.16% <100.00%> (+0.76%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.