interceptor icon indicating copy to clipboard operation
interceptor copied to clipboard

Unmarshal only actually read bytes

Open braams opened this issue 1 year ago • 2 comments

Description

The interceptor tried to unmarshal the whole buffer and didn't respect the actual packet length.

Reference issue

Fixes #255

braams avatar Jun 17 '24 09:06 braams

Let me add some tests around this, unless you wish to, and then we can get this merged.

thatsnotright avatar Aug 30 '24 16:08 thatsnotright

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.48%. Comparing base (f42ed2b) to head (561796c). Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #257      +/-   ##
==========================================
- Coverage   72.56%   72.48%   -0.08%     
==========================================
  Files          79       79              
  Lines        3648     3653       +5     
==========================================
+ Hits         2647     2648       +1     
- Misses        867      869       +2     
- Partials      134      136       +2     
Flag Coverage Δ
go 72.48% <100.00%> (-0.08%) :arrow_down:
wasm ?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 02 '24 15:09 codecov[bot]