ice icon indicating copy to clipboard operation
ice copied to clipboard

Revert "Avoid allocation storing last active time"

Open jech opened this issue 1 year ago • 1 comments

This reverts commit edb69295c04429931ede6a3df01d49520a1b31dc.

In that commit, active time was changed from time.Time to Unix time in order to avoid allocations. Unfortunately, that has the side effect of discarding the monotonic component of time.Time, and therefore makes our code vulnerable to stepping of the system clock.

This carries over #698 to v3. Fixes #697.

jech avatar May 09 '24 10:05 jech

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.19%. Comparing base (899594c) to head (4636318).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #699   +/-   ##
=======================================
  Coverage   79.19%   79.19%           
=======================================
  Files          41       41           
  Lines        3739     3739           
=======================================
  Hits         2961     2961           
  Misses        547      547           
  Partials      231      231           
Flag Coverage Δ
go 79.19% <100.00%> (ø)
wasm 22.13% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 09 '24 10:05 codecov[bot]