explainer icon indicating copy to clipboard operation
explainer copied to clipboard

Updated the web APP UI

Open ahmed-adly-khalil opened this issue 4 years ago • 4 comments

Created a react version of the web explainer. Please let me know if there is anything that needs to be changed

https://user-images.githubusercontent.com/36244069/149459967-3eb5e168-f3f6-49c9-9700-6eb804c2f31c.mov

ahmed-adly-khalil avatar Jan 14 '22 05:01 ahmed-adly-khalil

Amazing work @ahmed-adly-khalil! Love the UI improvements. I am worried about some of the dependencies we are going to take on though.

  • npm and node isn't available/installed everywhere. Some companies have a list of languages and tools, and this would block them.
  • react and tailwind means this won't be integrated as much. If a project is already using angular or vue they are going to disregard this project.

I am not against any of the libraries chosen. If we absolutely need them/can't ship without them it makes sense to use them. If they are just nice to have I think we should avoid using them. My hope is that we can keep this project is simple/easy to integrate as possible and grow from there.

Sean-Der avatar Jan 14 '22 15:01 Sean-Der

Hello @Sean-Der

Sounds good, I will keep the same UI with pure JavaScript and remove deps. For css tailwind can be included as a script tag so I guess that would be ok?

ahmed-adly-khalil avatar Jan 14 '22 15:01 ahmed-adly-khalil

Codecov Report

Merging #7 (fbee3d1) into master (78b1418) will not change coverage. The diff coverage is n/a.

:exclamation: Current head fbee3d1 differs from pull request most recent head e04825c. Consider uploading reports for the commit e04825c to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##           master       #7   +/-   ##
=======================================
  Coverage   68.79%   68.79%           
=======================================
  Files           7        7           
  Lines         266      266           
=======================================
  Hits          183      183           
  Misses         79       79           
  Partials        4        4           
Flag Coverage Δ
go 68.79% <ø> (ø)
wasm 36.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 78b1418...e04825c. Read the comment docs.

codecov-commenter avatar Jan 17 '22 06:01 codecov-commenter

@Sean-Der Done, I have converted to vanilla javascript + only tailwind CSS for styling and kept the exact same UI as the react version. Please let me know if further changes are needed

ahmed-adly-khalil avatar Jan 17 '22 06:01 ahmed-adly-khalil