dtls icon indicating copy to clipboard operation
dtls copied to clipboard

Handshake fragments assembly refactoring

Open trs00 opened this issue 1 month ago • 1 comments

  • Determining the end of the fragment by looking at the fragment length, rather than handshake header's length
  • Using totalBufferSize to avoid walks the linked list to determine the total buffer size
  • Using totalFragmentCount to avoid list grow to an unbounded size with 0-length fragments
  • Removing the need to try to reassemble(by recursively calling a function for each fragment) on every new packet

trs00 avatar Dec 15 '25 20:12 trs00

Codecov Report

:x: Patch coverage is 97.61905% with 1 line in your changes missing coverage. Please review. :white_check_mark: Project coverage is 81.26%. Comparing base (ab5f89b) to head (963b7c8). :warning: Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
fragment_buffer.go 97.61% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #762      +/-   ##
==========================================
+ Coverage   81.16%   81.26%   +0.09%     
==========================================
  Files         101      101              
  Lines        5597     5603       +6     
==========================================
+ Hits         4543     4553      +10     
+ Misses        678      676       -2     
+ Partials      376      374       -2     
Flag Coverage Δ
go 81.26% <97.61%> (+0.09%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Dec 15 '25 20:12 codecov[bot]

Thank you so much @trs00! Changes look great to me.

Would you be able/interested in fixing the lints? If you don't have time I am happy to push to your branch directly :)

Sean-Der avatar Dec 16 '25 03:12 Sean-Der

@Sean-Der thanks a lot for looking into PR, I pushed lint fixes

trs00 avatar Dec 16 '25 16:12 trs00

@JoeTurki may I ask if merge option is not available due to access restrictions or it is necessary to have 100% Patch coverage?

trs00 avatar Dec 18 '25 19:12 trs00

@trs00 Hello, I squash merged, If you plan to make more changes, I can send you an invite to the org so you can make branches directly, and merge PRs after approval :)

Thank you a lot.

JoTurk avatar Dec 18 '25 19:12 JoTurk