pints
pints copied to clipboard
Tweaks to Adam
Also played with boundaries, but that just caused the method to run out of momentum & get stuck so abandoned the idea.
Made a PR anyway because in the meantime I
- added pseudo code
- added two values to its logging output
- improved testing & fixed a bug in the irpropmin test
Not at all urgent, but would still be nice if you could have a look @DavAug
Codecov Report
Patch coverage: 100.00% and no project coverage change.
Comparison is base (
931d02b) 100.00% compared to head (9609376) 100.00%.
:exclamation: Current head 9609376 differs from pull request most recent head 6ca0d19. Consider uploading reports for the commit 6ca0d19 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## master #1469 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 97 97
Lines 9532 9530 -2
=========================================
- Hits 9532 9530 -2
| Impacted Files | Coverage Δ | |
|---|---|---|
| pints/_optimisers/_adam.py | 100.00% <100.00%> (ø) |
... and 3 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Anyone feel like reviewing this @pints-team/devs ? It's mostly just documentation improvements! 5 minute job