pints icon indicating copy to clipboard operation
pints copied to clipboard

TransformedBoundaries and TransformedLogPrior don't override full interface

Open MichaelClerx opened this issue 4 years ago • 2 comments

~In https://github.com/pints-team/pints/blob/master/pints/_transformation.py we have TransformedBoundaries and a TransformedLogPrior that implement some, but not all, of the methods in Boundaries and LogPrior. This means the remaining methods will return results using untransformed parameters.~

~E.g. the boundaries have a transformed range() method, but no transformed lower() or upper() methods. Neither class performs sampling.~

MichaelClerx avatar Sep 22 '21 15:09 MichaelClerx

The Boundaries class doesn't define a range, upper, or lower, so the TransformedBoundaries shouldn't either

MichaelClerx avatar Aug 11 '22 15:08 MichaelClerx

TransformedBoundaries is missing a sample method

MichaelClerx avatar Aug 11 '22 16:08 MichaelClerx

Closed in #1450

MichaelClerx avatar Aug 11 '22 20:08 MichaelClerx