pints icon indicating copy to clipboard operation
pints copied to clipboard

NestedSampler abstract class predefine _needs_sensitivity

Open chonlei opened this issue 4 years ago • 1 comments

Not sure if this is a good practice that in the NestedSampler, self._needs_sensitivity is always needed (e.g. needs_sensitivities() method), but it is never defined in the abstract class. At the moment it is only provided in each subclass. So it works fine but when I was looking through the code I was expecting if the subclass doesn't define that would raise NotImplementedError but maybe not AttributeError...? Unless I've missed it somewhere!

chonlei avatar Jul 04 '20 13:07 chonlei

Yep, sounds about right!

MichaelClerx avatar Jul 04 '20 15:07 MichaelClerx