xy-VSFilter icon indicating copy to clipboard operation
xy-VSFilter copied to clipboard

64-bit timestamps

Open slydiman opened this issue 6 years ago • 4 comments

Hello k-lite codec pack uses your xy-VSFilter since v14.8.4 instead of VSFilter from mpc-hc. But your xy-VSFilter uses 32-bit timestamps internally and lose timestamps in case of very long streams. Please apply the following patch https://github.com/mpc-hc/mpc-hc/commit/04f914f92c894b43fdead49f7ce50c023826b43b Thanks

slydiman avatar May 12 '19 09:05 slydiman

Thanks for the link. I'll do that, it does not require deep knowledge of project history :)

pinterf avatar May 13 '19 10:05 pinterf

Thank you very much.

slydiman avatar May 13 '19 11:05 slydiman

Hi, time goes on, but thing are not forgotten. The patch could not be applied as-is, the files are so much different that VS wanted to delete the affected files :) instead of merge during the cherry pick. So I went through the differences manually. Then I'm gonna amend the commit to put you back as author. A question: exactly how long is a 'very long stream' in the 32 bit world?

pinterf avatar Mar 06 '21 19:03 pinterf

In this case is ~596 hours I think.

clsid2 avatar Mar 06 '21 23:03 clsid2