xy-VSFilter icon indicating copy to clipboard operation
xy-VSFilter copied to clipboard

Published 20 hours ago • verified publisher icon pinterf

Deadlock

Open clsid2 opened this issue 5 years ago • 2 comments

There is a deadlock that sometimes occurs while unloading VSFilter. It happens when at same time SetupFRD function is called from inside the loop in CDirectVobSubFilter::ThreadProc().

Related commit, which only partially fixed it: https://github.com/Cyberbeing/xy-VSFilter/commit/d7ccef214c78584424aab16c1684f8d307d25826

One solution would be to remove the lock inside the destructor CDirectVobSubFilter::~CDirectVobSubFilter()

To reproduce use MPC-HC with subtitle renderer set to VSFilter and a couple videos that don't have subtitles. Then quickly keep loading files (e.g. with PageUp/PageDown) and eventually it will hang.

clsid2 avatar May 23 '19 11:05 clsid2

Just returned to the project, do you know whether this one was fixed already? Is it serious/really needs investigation? Yes, i know, the project is between dead/half-dead.

pinterf avatar Mar 05 '21 09:03 pinterf

Nope, not fixed afaik. It was pretty easy to trigger if I remember correctly.

clsid2 avatar Mar 05 '21 11:03 clsid2