mvtools icon indicating copy to clipboard operation
mvtools copied to clipboard

Fix for unbiased integer

Open DTL2020 opened this issue 1 year ago • 3 comments

division error

DTL2020 avatar Mar 07 '23 19:03 DTL2020

If you force push with your fixes, your pull request will be renewed and won't contain fix of a previous wrong commit.

pinterf avatar Mar 08 '23 12:03 pinterf

If you force push with your fixes, your pull request will be renewed and won't contain fix of a previous wrong commit.

And how to 'force push' via github web-interface ? I thought the all changes (all sequential commits) of this branch 'fixed_css_error' will be merged in single pull-request.

DTL2020 avatar Mar 08 '23 13:03 DTL2020

I think your differently named commits will all appear as you provided it. If possible, I wouldn't like to see all the development and experimenting phase in the repo. Too many changes to and fro. This is why I lately removed partially imported changes from your branch from my mvtools2 repo on my home computer; there are some uncommitted changes on my side.

I suppose when you reset your local working branch (keep changes) and reapply commits and make a force-push it will automatically appear proeprly in the pull request, Lately an Avisynth contributors was routinely doing it, so it cannot be that difficult.

Like here, original pull request was made ready after several iterations: https://github.com/AviSynth/AviSynthPlus/pull/335

I, personally never used it from the other side, but I'm gonna try once to see how it works in real life.

pinterf avatar Mar 10 '23 15:03 pinterf